Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ruleset-bundler): rollup plugin commonjs is a dev dependency #2564

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

w3nl
Copy link

@w3nl w3nl commented Dec 15, 2023

Fixes #2563.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

For @stoplight/spectral-ruleset-bundler it is not needed to have this as a normal dependency.
Only used in a test, so not needed to set to the dependencies.

For @stoplight/spectral-cli it is used, so that package should have it as a dependency.

If indicated yes above, please describe the breaking change(s).

Remove this quote before creating the PR.

Additional context

Also fixes a Snyk issue of inflight
https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
@stoplight/spectral-ruleset-bundler@1.5.2 › @rollup/plugin-commonjs@25.0.7 › glob@8.1.0 › inflight@1.0.6

@w3nl w3nl requested a review from a team as a code owner December 15, 2023 22:25
@w3nl w3nl changed the title rollup plugin commonjs is a dev dependency chore(spectral-ruleset-bundler): rollup plugin commonjs is a dev dependency Dec 15, 2023
@w3nl w3nl changed the title chore(spectral-ruleset-bundler): rollup plugin commonjs is a dev dependency chore(ruleset-bundler): rollup plugin commonjs is a dev dependency Dec 15, 2023
Update rollup commonjs package to 25
@P0lip P0lip force-pushed the develop branch 3 times, most recently from dc90b7a to c22f408 Compare April 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup plugin commonjs should be a dev dependency
2 participants