fix(rulesets): make rule oas2-operation-formData-consume-check consistent with Swagger Editor similar rule
#2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent with Swagger Editor
|
@P0lip, where can i find the failing test file? |
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
dc90b7a
to
c22f408
Compare
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger Editor has a similar rule to check values of
consumesarray:https://github.com/swagger-api/swagger-editor/blob/249d4f0044d2104fdbe582cf53f27f3538b361d7/src/plugins/validate-semantic/validators/form-data.js#L50-L96
The difference is that Spectral rule does not fail if
consumesarray is completely missing which seems to be a mistake.Checklist
Does this PR introduce a breaking change?
Potentially, it might be a breaking change for those who use this rule as it will though an additional validation issue in this edge case.