-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(formatters): add GitHub Actions formatter #2508
feat(formatters): add GitHub Actions formatter #2508
Conversation
e91eeb4
to
f4c90b2
Compare
f4c90b2
to
3295bd4
Compare
I'll try to take a look at it this week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a potential column mismatch, this looks great.
Thanks a lot for the contribution!
# Conflicts: # packages/formatters/src/github-actions.ts
77cddc0
to
0b0c635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again!
I'll merge and release it today
Could you merge the latest develop branch? it's out of sync with the base branch |
@P0lip merged, sorry for the delay; I was in the dream 💤 |
# @stoplight/spectral-formatters [1.2.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-formatters-1.1.0...@stoplight/spectral-formatters-1.2.0) (2023-07-26) ### Features * **formatters:** add GitHub Actions formatter ([#2508](#2508)) ([6904927](6904927))
This pull requests add a built-in formatter for annotating errors in GitHub Actions.
Spectral already have spectral-action for running Spectral and annotating errors in the workflow. The action creates a new check entry to annotate, but sometimes the annotation is incorrectly attached to another job due to GitHub's bug. To avoid that, it would be great if the Spectral CLI support formatting errors to GitHub Actions format 1 as a built-in formatter, as same as TeamCity formatter does.
Checklist
Does this PR introduce a breaking change?
Screenshots
N/A
Additional context
N/A
Footnotes
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message ↩