feat(formatters): move formatters to a separate package #2468
Conversation
sennyeya
force-pushed
the
formatters
branch
2 times, most recently
from
bcb7afb
to
eb169fc
Compare
|
Couple of questions:
|
sennyeya
changed the title
|
@P0lip Any ideas on why the Karma tests are failing? I think it's related to |
|
Yeah, that is most likely due to the HTML formatter relying on |
|
#2474 - WIP |
|
Great, thanks! |
|
@sennyeya could you merge the latest changes when you have a minute? 馃檹 that should unblock test-browser 馃 |
sennyeya
force-pushed
the
formatters
branch
2 times, most recently
from
0c14d35
to
8ffedc8
Compare
|
@P0lip It looks like Other than that, everything should be good minus the commit message (what's the format for those?) |
Signed-off-by: Aramis Sennyey <sennyeyaramis@gmail.com>
it has to be accepted by commitlint per its config here https://github.com/stoplightio/spectral/blob/develop/commitlint.config.js |
|
I'll take a final look on Monday, and if it's all good I will proceed and merge it. |
|
@P0lip Thanks for your help pushing this through! |
# [6.7.0](v6.6.0...v6.7.0) (2023-05-23) ### Bug Fixes * **core:** improve deep ruleset inheritance ([#2326](#2326)) ([378b4b8](378b4b8)) * **core:** more accurate ruleset error paths ([66b3ca7](66b3ca7)) * **core:** reset path in fn context ([#2389](#2389)) ([3d47ec4](3d47ec4)) * **ref-resolver:** bump @stoplight/json-ref-resolver from ~3.1.4 to ~3.1.5 ([#3635](https://github.com/stoplightio/spectral/issues/3635)) ([215ae93](215ae93)) * **ruleset-bundler:** defaults should be last one ([#2403](#2403)) ([8780cfa](8780cfa)) * **ruleset-bundler:** remove extraneous 'external dependency' warnings ([#2475](#2475)) ([e791534](e791534)) * **ruleset-migrator:** avoid positive lookbehinds ([#2349](#2349)) ([455c324](455c324)) * **ruleset-migrator:** transform functions under overrides ([#2459](#2459)) ([45e817f](45e817f)) * **ruleset-migrator:** use module for require.resolve ([#2405](#2405)) ([d7c0fa4](d7c0fa4)) * **rulesets:** avoid false errors from ajv ([#2408](#2408)) ([92dab78](92dab78)) * **rulesets:** length.min said "must not be longer than" ([#2355](#2355)) ([df3b6f9](df3b6f9)) ### Features * **core:** relax formats validation ([#2151](#2151)) ([de16b4c](de16b4c)) * **core:** support end-user extensions in the rule definitions ([#2345](#2345)) ([365fced](365fced)) * **core:** support x- extensions in the ruleset ([#2440](#2440)) ([964151e](964151e)) * **formats:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([b8e51b4](b8e51b4)) * **formatters:** move formatters to a separate package ([#2468](#2468)) ([664e259](664e259)) * **rulesets:** add traits array path to headers rule ([#2460](#2460)) ([9ceabca](9ceabca)) * **rulesets:** support AsyncAPI 2.6.0 ([#2391](#2391)) ([94a7801](94a7801))
|
馃帀 This PR is included in version 6.7.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
馃帀 This PR is included in version 1.18.1 馃帀 The release is available on npm package (@latest dist-tag) Your semantic-release bot 馃摝馃殌 |
Fixes #2467. Moves the formatters to their own package that is then imported by
@stoplight/spectral-cli.馃憖 @P0lip
Checklist
Existing tests should cover any issues, this PR is just a move with additional dependency work.
Does this PR introduce a breaking change?
The formatters for the CLI have been pulled out to their own package, not necessarily breaking for any contracts, but will require pulling in a new package on CLI version update.
Additional context
I wasn't sure if this should sit in
packages/coreor a separate package, I think it makes sense to pull it completely out as it's not core functionality and just a presentation layer, but I could go either way.