Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: package readmes #1695

Closed
wants to merge 5 commits into from
Closed

chore: package readmes #1695

wants to merge 5 commits into from

Conversation

domagojk
Copy link
Contributor

@domagojk domagojk commented Jun 25, 2021

Addresses stoplightio/platform-internal#6806

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@domagojk
Copy link
Contributor Author

c/p from slack:

I've moved docs from guides to cli, rulestes, functions and formats packages and adjusted some links for it. But guide is broken for now since I don't know how to solve that, and I also wrote very basic list of packages in Contributing.md (some of them I don't know how to describe)
Overall I'm not too happy how it looks 🙂 I think I liked root level guide more than this 🤷

@@ -21,7 +33,7 @@ Yarn is a package manager for your code, similar to npm. While you can use npm t
3. In your terminal, navigate to the directory you cloned Spectral into (check that you are on the `develop` branch).
4. Install the dependencies: `yarn`
5. Build Spectral: `yarn build`
6. Run Spectral from your local installation: `yarn cli lint [openapi_spec_file]`
6. Run Spectral from your local installation: `yarn cli cli lint [openapi_spec_file]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, first cli is a name of yarn workspace and a second one is the name of the command. But it sure does look odd. Maybe we should add cd packages/cli && yarn cli lint [openapi_spec_file] or create a custom cli command in root? @P0lip wdyt?

Copy link
Contributor

@P0lip P0lip Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 6a7a4e5

@@ -38,7 +38,7 @@ extends:
- https://raw.githubusercontent.com/openapi-contrib/style-guides/master/apisyouwonthate.yml
```

As with any ruleset, you can pass these directly to the [Spectral CLI](./2-cli.md):
As with any ruleset, you can pass these directly to the [Spectral CLI](../../cli/README.md):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work when the package is published to NPM?
I doubt it'll - perhaps we link to meta.stoplight.io?

@P0lip
Copy link
Contributor

P0lip commented Jan 27, 2022

@mnaumanali94 may we find some volunteers to get this over the finish line? 😆

@P0lip P0lip force-pushed the develop branch 2 times, most recently from dc9d7f4 to 44c40e2 Compare May 23, 2023 22:56
@P0lip P0lip force-pushed the develop branch 4 times, most recently from 02ec0d4 to 84faec8 Compare June 9, 2023 19:43
@P0lip P0lip force-pushed the develop branch 3 times, most recently from 9e92f34 to 6d09915 Compare September 20, 2023 18:42
@P0lip P0lip force-pushed the develop branch 3 times, most recently from dc90b7a to c22f408 Compare April 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants