Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export types in exports field #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jigsawye
Copy link

Motivation and Context

see stoplightio/elements#2392

Description

How Has This Been Tested?

Screenshot(s)/recordings(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@weyert
Copy link

weyert commented Dec 12, 2023

Same issue exists for @stoplight/json-schema-viewer would be nice if this could be merged

+  "exports": {
+    ".": {
+      "require": {
+        "types": "./index.d.ts",
+        "default": "./index.js"
+      },
+      "import": {
+        "types": "./index.d.ts",
+        "default": "./index.mjs"
+      }
+    }
+  }
}

@venables
Copy link

venables commented Apr 3, 2024

👍

This PR allows @stoplight/elements to work with the default settings in the latest create-next-app.

Basically if moduleResolution is bundler in tsonfig.json (which is the default in create-next-app) you can't use @stoplight/elements without patching the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants