Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.1 compat #166

Closed
wants to merge 4 commits into from
Closed

php 8.1 compat #166

wants to merge 4 commits into from

Conversation

danesteve
Copy link
Contributor

@danesteve danesteve commented Jan 4, 2022

PHP 8.1 compatibility.

Summary of changes:

  • Add ReturnTypeWillChange annotations to keep BC with php 7
  • Reenable convertDeprecationsToExceptions in phpunit (changed it's default behaviour in 9.5.10)
  • Update phpunit code coverage config (changed in 9.3.0)
  • Update phpunit deprecated setMethods

Will appreciate if you could tag a new release if this get merged.

Regards.

@danesteve
Copy link
Contributor Author

The phpstan issues seems to be unrelated to this PR.

Also some tests seem to be a bit flaky, maybe increasing timeouts would help.

$this->Stomp->getConnection()->setReadTimeout(0, 750000);

@danesteve
Copy link
Contributor Author

Hi @jmglsn, @staabm. Can you take a look at the changes?

@jmglsn
Copy link
Member

jmglsn commented Jan 17, 2022

@danesteve I need to admit that I have almost no free time left. Thank you for working on this, I'll try to review but it might take a week, sorry.

@danesteve
Copy link
Contributor Author

danesteve commented Jan 17, 2022

No problem @jmglsn, thank you for your time.

@jmglsn
Copy link
Member

jmglsn commented Mar 6, 2022

... months passed by and I was not able to check.
Another war started, my son got infected and I almost lost my roof as the storm reached unknown speeds.
I'll do it but if I fail, please don't judge too hard.

@danesteve
Copy link
Contributor Author

Sorry to hear that. Hope everything is ok.
Of course personal life should always come first.
Wish you all the best.

@D0L1K
Copy link

D0L1K commented Jul 19, 2022

Hi, any news about this? Would love to switch to PHP 8.1 with full support of stomp-php

@kkrasnik
Copy link

kkrasnik commented Nov 4, 2022

Hi @jmglsn.
Is there a chance that you will continue this PR? Or maybe you quit this project?

@whikloj
Copy link
Collaborator

whikloj commented Jun 15, 2023

PHP 8.2 is now out and 8.0 is close to EOL. Is there anything I can do to assist in moving this forward?

@jmglsn
Copy link
Member

jmglsn commented Jun 19, 2023

@whikloj I invite you to become a maintainer for this lib.

The situation for me changed dramatically and I'll focus on spending time with my kids and wife.

@whikloj
Copy link
Collaborator

whikloj commented Jun 19, 2023

Hey @jmglsn, I hope you and your family are well. I'll try to keep this going as well as I can and hopefully you might pop in from time to time to ensure I'm not breaking anything 😆

@staabm
Copy link
Member

staabm commented Jun 19, 2023

Thanks for the support. I would also have a look at this PR after vacation

@whikloj
Copy link
Collaborator

whikloj commented Jun 19, 2023

Hey @staabm. I apologize that I merged #174 which was my PR and included these changes along with some Github actions changes.

This PR fixes deprecated methods in the testing tools and adds a bunch of #[\ReturnTypeWillChange] annotations.

As this had been sitting for 17 months I thought no one had time. I can revert my merge if you'd like to check through this.

@staabm
Copy link
Member

staabm commented Jun 19, 2023

No worries. Please go ahead

@whikloj
Copy link
Collaborator

whikloj commented Jun 19, 2023

Closing as was subsumed by #174

@whikloj whikloj closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants