New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php 8.1 compat #166
php 8.1 compat #166
Conversation
The phpstan issues seems to be unrelated to this PR. Also some tests seem to be a bit flaky, maybe increasing timeouts would help.
|
@danesteve I need to admit that I have almost no free time left. Thank you for working on this, I'll try to review but it might take a week, sorry. |
No problem @jmglsn, thank you for your time. |
... months passed by and I was not able to check. |
Sorry to hear that. Hope everything is ok. |
Hi, any news about this? Would love to switch to PHP 8.1 with full support of stomp-php |
Hi @jmglsn. |
PHP 8.2 is now out and 8.0 is close to EOL. Is there anything I can do to assist in moving this forward? |
@whikloj I invite you to become a maintainer for this lib. The situation for me changed dramatically and I'll focus on spending time with my kids and wife. |
Hey @jmglsn, I hope you and your family are well. I'll try to keep this going as well as I can and hopefully you might pop in from time to time to ensure I'm not breaking anything 😆 |
Thanks for the support. I would also have a look at this PR after vacation |
Hey @staabm. I apologize that I merged #174 which was my PR and included these changes along with some Github actions changes. This PR fixes deprecated methods in the testing tools and adds a bunch of As this had been sitting for 17 months I thought no one had time. I can revert my merge if you'd like to check through this. |
No worries. Please go ahead |
Closing as was subsumed by #174 |
PHP 8.1 compatibility.
Summary of changes:
ReturnTypeWillChange
annotations to keep BC with php 7convertDeprecationsToExceptions
in phpunit (changed it's default behaviour in 9.5.10)setMethods
Will appreciate if you could tag a new release if this get merged.
Regards.