New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating sync intervals #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update, a few cosmetic changes and a few (open) suggestions to consider.
Thanks 🤝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlegSternbergIBM @vMaroon
I've added some comments.
pkg/controller/dbsyncer/intervalpolicy/syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
pkg/controller/dbsyncer/intervalpolicy/syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
pkg/controller/dbsyncer/intervalpolicy/default_syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
pkg/controller/dbsyncer/intervalpolicy/default_syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
pkg/controller/dbsyncer/intervalpolicy/default_syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
pkg/controller/dbsyncer/intervalpolicy/syncer_interval_policy.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added one more minor comment/question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlegSternbergIBM looks good.
left a few more comments that require minor changes..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlegSternbergIBM looks good.
left one last comment (very very minor) and one point for us to remember.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, OlegSternbergIBM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this change a bundle syncer adjusts its periodic interval according to the load it creates on transport.
The approach is - each bundle syncer receives a "policy" which returns an interval.
A simple default policy implementation is provided is this change.