Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32h7: split ethernet peripheral for dualcore parts #288

Merged
merged 1 commit into from
Oct 22, 2019
Merged

stm32h7: split ethernet peripheral for dualcore parts #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions devices/common_patches/h7_ethernet_combined_desc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Applies to H7 where MAC and MTL registers are combined under
# the Ethernet_MAC peripheral

# Create separate DMA and MTL periperhals
_include:
- ./h7_ethernet_dma.yaml
- ./h7_ethernet_mtl.yaml

Ethernet_MAC:
# Delete DMA and MTL parts from MAC
_delete:
_registers:
- DMA*
- MTL*

# Descriptions for MAC
_include:
- ./h7_ethernet_desc_mac.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not looking at this earlier - should this line be Ethernet_DMA?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is redundant. There's no need for separate description listings for MTL or DMA, because the descriptions are included in the standalone peripheral definitions here:

# Create separate DMA and MTL periperhals
_include:
  - ./h7_ethernet_dma.yaml
  - ./h7_ethernet_mtl.yaml

The desc_mac definitions are particularly misleading, as they're already included a few lines above. I'm therefore resolving by removing both description includes.

7 changes: 0 additions & 7 deletions devices/common_patches/h7_ethernet_desc_combined.yaml
View file
Open in desktop

This file was deleted.