stm32h7: split ethernet peripheral for dualcore parts #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgreig
reviewed
Oct 21, 2019
|
|
||
| Ethernet_MAC: | ||
| _include: | ||
| - ./h7_ethernet_desc_mac.yaml |
There was a problem hiding this comment.
Sorry for not looking at this earlier - should this line be Ethernet_DMA?
There was a problem hiding this comment.
Actually, this is redundant. There's no need for separate description listings for MTL or DMA, because the descriptions are included in the standalone peripheral definitions here:
# Create separate DMA and MTL periperhals
_include:
- ./h7_ethernet_dma.yaml
- ./h7_ethernet_mtl.yaml
The desc_mac definitions are particularly misleading, as they're already included a few lines above. I'm therefore resolving by removing both description includes.
Split periperal into (MAC, DMA, MTL) `h7_ethernet_desc_mtl` is not required as descriptions are already included in the `h7_ethernet_mtl` definitions.
richardeoin
force-pushed
the
h7-dualcore-split-ethernet
branch
from
6eea43c
to
c9348f4
Compare
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split ethernet peripheral into (MAC, DMA, MTL).
This brings it in line with single core parts.