Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect aria-modal Usage #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurencepresland
Copy link

This PR sets the value of the aria-modal attribute based on the value of the blocking prop. According to the MDN Web Docs the aria-modal attribute is designed to limit screen readers to a particular area of an application. Therefore I think it makes sense that it should be set in line with the blocking prop.

Without this fix there is no way to set aria-modal to false therefore screen readers which respect the attribute (currently only iOS as far as I know) will always be stuck in the bottom sheet.

@alex-reid
Copy link

+1 on this. This is currently breaking accessibility on iOS devices if the bottom sheet is set to blocking={false}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants