Django 4.0.0 compatibility, fixes #135 #136
Conversation
Django template tags `ifequal` and `ifnotequal` have been deprecated since 1.2. Change all templates to use `if` https://code.djangoproject.com/ticket/31532
Django 3.0.0 deprecated urlquote and 4.0.0 removed it. https://docs.djangoproject.com/en/dev/releases/3.0/#deprecated-features-3-0 Switch to use urllib.parse.quote() (urlquote was just an alias for it anyway)
Django 3.1 deprecated `url` and 4.0.0 removed it https://docs.djangoproject.com/en/3.2/ref/urls/#url Switch to use `django.urls.re_path()`
* Drop support for < Django1.5 (its been end of life since September 2, 2014 https://www.djangoproject.com/download/#unsupported-versions) * remove `providing_args` from signal definitions. Its purely documentational and has been removed in Django 4.0.0 (django/django@1adcf20#diff-65f7ef82645dcdb6a7898f2126781336c222437f65d3666c9d65b89edf725a6b) * smart_text was deprecated in Django 3.0 and removed in 4.0
tswfi
changed the title
|
@jerivas sorry to ping you, but I guess you have to approve the workflow to be ran again? I also enabled the Django4 parts of the workflow. |
|
ok, now the workflow should do its thing. @jerivas One more approval for the workflow please? |
|
ok, so tests and lint are fine but I have a feeling the release step should not be done in a pr (at least from my pr :) I'm not sure how the workflow is supposed to work. Any pointers @jerivas? |
|
@tswfi you're correct, the release step doesn't apply to this branch. It should just be skipped but I'm not sure why it's failing. We can ignore it for now, I'll just do some manual testing later this week and hopefully get this merged soon. Thanks for your initiative! |
|
Thanks for the help @tswfi. I tested locally and this is working great. Unfortunately the |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Add Django 4.0.0 compatibility.
ifequalandifnotequalhave been deprecated since 1.2. Change all templates to useifurland 4.0.0 removed it. Switch to usedjango.urls.re_path()providing_argsfrom signal definitions. Its purely documentational and has been removed in Django 4.0.0smart_textwas deprecated in Django 3.0 and removed in 4.0. Switch tosmart_strThis should make the package Django 4.0.0 compatible.
According to https://github.com/stephenmcd/filebrowser-safe/blob/master/README.rst#contributing this project follows Mezzanine's Contribution Guidelines but this repo does not have
AUTHORSfile. Not sure if it should be added so I left it out.