Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bytes crate #533

Closed
wants to merge 1 commit into from
Closed

update bytes crate #533

wants to merge 1 commit into from

Conversation

Tarnadas
Copy link
Contributor

No description provided.

@stepancheg
Copy link
Owner

Note CI is not green.

I suspect bytes 0.6 is backwards-incompatible with 0.5?

@Tarnadas
Copy link
Contributor Author

Yeah I should have tested this locally before pushing.

So there is this issue which has been fixed: tokio-rs/bytes#328
I am definitely not that familiar with unsafe casting, but I just pushed a change which should compile

@stepancheg
Copy link
Owner

stepancheg commented Nov 25, 2020

Any idea if it's possible to fix in a manner compatible with both bytes 0.5 and 0.6? Forcing everyone to upgrade is less perfect.

(I'll have a look myself later, but maybe you know the answer.)

@Tarnadas
Copy link
Contributor Author

The only thing I could think about is to split this up into multiple features, so there would be e.g. with-bytes05 and with-bytes06

@stepancheg
Copy link
Owner

That would be overkill.

@Tarnadas
Copy link
Contributor Author

I’m wondering why you would want to have compatibility for both versions?
I don’t think this could be easily achieved

@stepancheg
Copy link
Owner

I’m wondering why you would want to have compatibility for both versions?

Otherwise users of protobuf crate will be forced to upgrade their projects for compatibility with newer bytes.

I don’t think this could be easily achieved

Seems so.

@stepancheg
Copy link
Owner

Pushed to master with minor changes. Thanks! Now going to merge to 2.19 (next stable) branch.

@stepancheg stepancheg closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants