Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from outdated tempfile crate #373

Closed
wants to merge 3 commits into from

Conversation

glebpom
Copy link

@glebpom glebpom commented Jan 8, 2019

No description provided.

@stepancheg
Copy link
Owner

Note travis-ci failures.

@stepancheg
Copy link
Owner

OK, why do we need to upgrade tempfile to tempdir? I've just opened tempdir crate homepage and haven't found anything wrong: the project seems to be alive and there is no deprecation or suggestions to migrate to tempfile.

@glebpom
Copy link
Author

glebpom commented Jan 9, 2019

hey, sorry, that's a mistake. Just got messed with different variants of temp files management crates. The goal was to stop using outdated rand crate (v0.4), which was a dependency of tempdir (instead of tempfile, heh), which was used by protoc-rust version 2.2.2. In fact, it has already been fixed in a master version of protoc-rust. Closing the PR.

@glebpom glebpom closed this Jan 9, 2019
@stepancheg
Copy link
Owner

@glebpom I'm not sure what's fixed in master, but if some commit needs to be ported to stable branches, please open an issue or PR, because master won't be released any time soon. Thanks!

@glebpom
Copy link
Author

glebpom commented Jan 9, 2019

Please, take a look at #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants