TODO about read function overload

stepancheg · Jun 9, 2018 · fef1106 · fef1106
1 parent c5a0911
commit fef1106
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/protobuf/src/stream.rs b/protobuf/src/stream.rs
@@ -180,6 +180,7 @@ impl<'a> CodedInputStream<'a> {
         self.source.bytes_until_limit()
     }
 
+    // TODO: overload with `Read::read`
     pub fn read(&mut self, buf: &mut [u8]) -> ProtobufResult<()> {
         self.source.read_exact(buf)?;
         Ok(())
@@ -637,7 +638,9 @@ impl<'a> CodedInputStream<'a> {
         unsafe {
             target.set_len(count);
         }
-        self.read(target)?;
+        // () is here to make sure correct overload is called
+        // TODO: rename `read` function
+        let () = self.read(target)?;
         Ok(())
     }