Fix compute_size(value: &i32) for negative values

stepancheg · Jan 9, 2019 · 7a1524d · 7a1524d
1 parent 3ba9cb9
commit 7a1524d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/protobuf-test/src/common/v2/test_map_simple.rs b/protobuf-test/src/common/v2/test_map_simple.rs
@@ -22,6 +22,13 @@ fn test_map() {
     test_serialize_deserialize_no_hex(&map);
 }
 
+#[test]
+fn test_map_negative_i32_value() {
+    let mut map = TestMap::new();
+    map.mut_m().insert("two".to_owned(), -2);
+    test_serialize_deserialize("0a 10 0a 03 74 77 6f 10 fe ff ff ff ff ff ff ff ff 01", &map);
+}
+
 #[test]
 fn test_map_with_object() {
     let mut map = TestMap::new();

diff --git a/protobuf-test/src/common/v2/test_map_simple_pb.proto b/protobuf-test/src/common/v2/test_map_simple_pb.proto
@@ -5,7 +5,7 @@ option (rustproto.generate_accessors_all) = true;
 
 
 message TestMap {
-    map<string, uint32> m = 1;
+    map<string, int32> m = 1;
     map<string, TestMapEntry> mm = 2;
 }
 

diff --git a/protobuf/src/reflect/types.rs b/protobuf/src/reflect/types.rs
@@ -222,6 +222,10 @@ impl ProtobufType for ProtobufTypeInt32 {
     }
 
     fn compute_size(value: &i32) -> u32 {
+        // See also: https://github.com/protocolbuffers/protobuf/blob/bd00671b924310c0353a730bf8fa77c44e0a9c72/src/google/protobuf/io/coded_stream.h#L1300-L1306
+        if *value < 0 {
+            return 10
+        }
         rt::compute_raw_varint32_size(*value as u32)
     }