Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tracy to v0.10 #4328

Merged
merged 5 commits into from
May 31, 2024
Merged

Bump tracy to v0.10 #4328

merged 5 commits into from
May 31, 2024

Conversation

marta-lokhova
Copy link
Contributor

@marta-lokhova marta-lokhova commented May 17, 2024

Bump tracy to v0.10. Most notable update is the UI overhaul, which makes it much faster and smoother (see https://wolf.nereid.pl/posts/how-tracy-faster/ for a bit more info)

@graydon
Copy link
Contributor

graydon commented May 17, 2024

Generally I'm happy to track tracy upstream but there is a bit of awkwardness around rust. We also emit tracy events from soroban and so we need a precisely matched version of tracy-client as well as an unfortunate manual regeneration of the patched/forked tracy-client-sys crate we use locally due to various silly technical requirements.

I think it should be mostly sufficient to bump the tracy-client ref in Cargo.toml and then do cargo-install --locked bindgen and re-run the tracy-client-sys regenerate.sh script but if you want I can handle this part. Depends how much you want to fight with rust stuff.

@graydon
Copy link
Contributor

graydon commented May 23, 2024

Also depends on an update on the soroban side: stellar/rs-soroban-env#1417

@graydon
Copy link
Contributor

graydon commented May 24, 2024

Pushed a change on here that illustrates (it's not quite what needs to be here for a final change, as it references a PR git head over in rs-soroban-env, but .. roughly this is the idea!)

@marta-lokhova marta-lokhova self-assigned this May 28, 2024
github-merge-queue bot pushed a commit to stellar/rs-soroban-env that referenced this pull request May 31, 2024
@marta-lokhova
Copy link
Contributor Author

thanks for the fixes @graydon! LGTM.

@marta-lokhova
Copy link
Contributor Author

r+ c3b1269

@latobarita latobarita merged commit d25ad44 into stellar:master May 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants