Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize
BaseEffectRecord
by effect type literals so that it's possible to discriminate based on thetype
field. With this change code like the following type checks whereas before it would have had errors because the type ofeffect
wouldn't get appropriately narrowed in each case based on the value ofeffect.type
:Also added the
type_i
field to theTrade
interface since it was missing, which was preventing eventype_i
from working correctly to discriminate effect types.