fix(contract-client): when options should go first #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Apr 24, 2024
Shaptic
reviewed
Apr 24, 2024
chadoh
force-pushed
the
fix/contract-client-methods-with-no-args
branch
from
89b2e32
to
146c381
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
chadoh
force-pushed
the
fix/contract-client-methods-with-no-args
branch
from
146c381
to
219f71a
Compare
Make the `methodOptions` object the first argument for ContractClient methods that take no arguments. This makes it match the types generated by the CLI. In order to get eslint to stop complaining about TypeScript feature `Pick`, I also switched eslint's parser to `@typescript-eslint/parser`
chadoh
force-pushed
the
fix/contract-client-methods-with-no-args
branch
from
219f71a
to
7789035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
methodOptionsobject the first argument for ContractClient methods that take no arguments.This makes it match the types generated by the CLI.