Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the types related to event types. #916

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes the types related to event types. #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e998df7
Fixup monkeypatching event types
Shaptic Jan 29, 2024
d75aa32
Add changelog entry
Shaptic Jan 29, 2024
464f65f
Merge branch 'master' into monkeypatch-fix
Shaptic Feb 12, 2024
c921d7e
Merge branch 'master' into monkeypatch-fix
Shaptic Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -10,7 +10,8 @@ A breaking change will get clearly marked in this log.
## [v11.2.2](https://github.com/stellar/js-stellar-sdk/compare/v11.2.1...v11.2.2)

### Fixed
* Event streaming tests now pass on Node 20, which seems to have tighter conformance to the spec ([#917](https://github.com/stellar/js-stellar-sdk/pull/917)).
* Corrects the types in event source monkeypatching ([#916](https://github.com/stellar/js-stellar-sdk/pull/916)).
* The test suite now conforms to Node 20 (SSE seems to have tighter conformance to the spec ([#917](https://github.com/stellar/js-stellar-sdk/pull/917)).
* `@stellar/stellar-base` has been upgraded to its latest major version ([#918](https://github.com/stellar/js-stellar-sdk/pull/918), see [v11.0.0](https://github.com/stellar/js-stellar-base/releases/tag/v11.0.0) for release notes).


Expand Down
6 changes: 3 additions & 3 deletions types/dom-monkeypatch.d.ts
View file
Open in desktop
Expand Up @@ -31,9 +31,9 @@ interface EventSource extends EventTarget {
* event stream is set to "include", and false otherwise.
*/
readonly withCredentials: boolean;
readonly CLOSED: number;
readonly CONNECTING: number;
readonly OPEN: number;
readonly CLOSED: 2;
readonly CONNECTING: 0;
readonly OPEN: 1;
close(): void;
addEventListener<K extends keyof EventSourceEventMap>(
type: K,
Expand Down