New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #299: Types provided for effects, with Go Package being the ref… #635

Merged

Shaptic merged 6 commits into stellar:master from RabeaWahab:Issue-#299-types-for-effects

Apr 26, 2021

Commits on Apr 21, 2021

Issue stellar#299 : Types peovided for effects, with Go Package being …
```
…the reference, in addition to moving Asset and Offer Types to their own files.
```
RabeaWahab committed Apr 21, 2021
Copy the full SHA

1b3c7fb View commit details

Browse the repository at this point in the history
add IDs of effects

RabeaWahab committed Apr 21, 2021

Copy the full SHA

568e055 View commit details

Browse the repository at this point in the history
rearranged imports as recommended by eslint + added Trade type

RabeaWahab committed Apr 21, 2021

Copy the full SHA

e17fa6b View commit details

Browse the repository at this point in the history

Commits on Apr 26, 2021

Issue stellar#299 fix typos and * import since we have all effects im…
```
…ported
```
RabeaWahab committed Apr 26, 2021
Copy the full SHA

a6a22eb View commit details

Browse the repository at this point in the history
Issue stellar#299 forgot the typos to be commited in effects.ts

RabeaWahab committed Apr 26, 2021

Copy the full SHA

d1e8796 View commit details

Browse the repository at this point in the history
Corrected typos, and double checked the effects types for any other o…
```
…nes + removed a type that was a duplicate + CCHANGELOG entry
```
RabeaWahab committed Apr 26, 2021
Copy the full SHA

ef35875 View commit details

Browse the repository at this point in the history