[ANCHOR-622] Redefine clients configuration with a schema and a separate file #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijamie98
commented
Mar 26, 2024
| assets: | ||
| # The type of the assets definition. | ||
| # The type of the asset definition. | ||
| # `type` can be one of the following: |
There was a problem hiding this comment.
We will drop in-place assets definition which is a feature not used.
Ifropc
reviewed
Mar 26, 2024
JiahuiWho
reviewed
Mar 27, 2024
JiahuiWho
reviewed
Mar 27, 2024
| Configuration for Stellar anchor clients, distinguishing between custodial and non-custodial clients. | ||
| properties: | ||
| custodial_clients: | ||
| type: array |
There was a problem hiding this comment.
nit: List? Let's unify the terminology :)
There was a problem hiding this comment.
We usually use plural for list. Can you help pointing out the inconsistencies?
There was a problem hiding this comment.
My bad. I mean since it is described as List (List of custodial clients. Defaults to an empty list), shall we just use type List instead of Array?
There was a problem hiding this comment.
I do not see there is a type list in OpenAPI spec though. https://swagger.io/docs/specification/data-models/data-types/
Can you help to give me the reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redefine clients configuration with a schema and a separate file
Context
For version 3.0.0
Testing
./gradlew testDocumentation
TODO: If this pull request adds a feature, describe changes to documentation that has been made