Bump windows-sys to 0.48.0 #93
Conversation
|
Looks like Appveyor has issues with TLS now and it's unable to download rust installer or crates. I'd be glad if you help me with this or just check it locally to make sure all tests pass. |
|
By the way, maybe you want to migrate to Github Actions? It's usually more reliable and has Windows Server 2022 and 2019 images. I can submit a PR for that if you want to. |
|
@KapJI yeah fine with migrating there vs spending time to fix it until the next appveyor thing breaks the next thing. |
|
@KapJI should be done. |
|
I rebased this PR but GH checks need approval. That's quite annoying and I usually change this setting to only require approval from new github users in my repos. This can be done in repo settings: Also looks like Appveyor needs to be disabled in Settings->Webhooks. Because now it fallbacks to default config. |
|
@KapJI Changed setting, appveyor is fully removed already but that preexisting last build check sticks around. |
|
Released as v0.1.22 |
|
Thanks @KapJI and @steffengy for getting this done! |
Summary: It includes steffengy/schannel-rs#93 which removes dependency on old version of `windows-sys` (or `winapi` in this case). Now we should less dependencies on older `windows-sys` which should make it easier to maintain. Reviewed By: zertosh Differential Revision: D47195354 fbshipit-source-id: 301132c32148ce08599636b4c9688ac12597459a
Updated version of #89.
Release notes: https://github.com/microsoft/windows-rs/releases/tag/0.48.0
CRYPTOAPI_BLOBrenamed toCRYPT_INTEGER_BLOB: microsoft/win32metadata@a357030windows-sys-0.43changed encoding for all string constants: Provide original encoding for string constants microsoft/windows-rs#2101null_terminate!removed as it's no longer needed.UNISP_NAME_A.SCHANNEL_RS_SKIP_SERVER_TESTS=1as I don't want to install new certs on my machine).