Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default email address of github-actions[bot] #264

Merged

Conversation

Teko012
Copy link
Contributor

@Teko012 Teko012 commented Nov 13, 2022

GitHub uses the new email format by default at commits when the github-actions[bot] is being used. This should bring it inline with that.

@stefanzweifel
Copy link
Owner

Thanks! I will take a closer look later today.

Copy link
Owner

@stefanzweifel stefanzweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay and everything works as expected.

But I don't understand why this change is exactly necessary.
(I personally like, that the used email by the Action is "clean" and doesn't contain an ID.)

Do you think this should be changed, because the Action was created after July 2017? Like how GitHub explains the difference of the email addresses on their docs page.

Where did you get the 41898282 ID from? Did you figure the ID out by using an API endpoint?

Did you ran into any issues with the old way of how the Action works?
Thanks for your feedback.

@Teko012
Copy link
Contributor Author

Teko012 commented Nov 13, 2022

Originally there were two reasons why I started looking into this: some of the commits made by actions were Co-authored-by by the action itself (with the old email format), and it also showed up as github-actions[bot] and github-actions[bot] committed. I looked at git log, and I noticed that the actual commit author email was the one with the ID included.

If you look at the API, the user was created on 2018-07-30T09:30:16Z, a year after they started using their new format. You can also see the id there.

So I think the right email to use would be the one with the ID, but you could double check it of course to see if you see the same behaviour in workflows, just to make sure :)

@stefanzweifel
Copy link
Owner

Thanks for the explanation.
I think that make sense to merge this PR and align it the behaviour of this Action with the "pattern" GitHub uses for the noreply-email adresses for GitHub accounts.

Will merge this to master now and tag a new version in the next couple of days.
Some people are using main in their workflows. Maybe some users will report weird behaviour because of this (probably not but you never know)

@stefanzweifel stefanzweifel changed the title Fix github-actions[bot] email address Update default email address of github-actions[bot] Nov 15, 2022
@stefanzweifel stefanzweifel merged commit 976f220 into stefanzweifel:master Nov 15, 2022
@Teko012 Teko012 deleted the fix/fix-github-action-bot branch November 15, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants