Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PnP aware Yarn in CI. #7

Merged
merged 4 commits into from Feb 27, 2019
Merged

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Feb 27, 2019

No description provided.

Copy link
Owner

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
It also seems like the test passes on my machine with 10.9, and fails with 11.9. Could be my 10.9 environment is hosed?

@stefanpenner
Copy link
Owner

I suspect the yarn version in windows is old, let me bump it

@@ -12,6 +12,7 @@ environment:

install:
- ps: Install-Product node $env:nodejs_version
- choco install yarn --version=1.13.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if this works

@stefanpenner
Copy link
Owner

Ok that got us 1 step closer

'require(resolve-package-path)(ember-source-channel-url,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Invalid or unexpected token
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:653:30)
    at evalScript (bootstrap_node.js:479:27)
    at startup (bootstrap_node.js:180:9)
    at bootstrap_node.js:625:3
error Command failed with exit code 1.
$ node -r ./.pnp.js -e 'require("resolve-package-path")("ember-source-channel-url", __dirname)'

windows escaping FTL, going to move that test into its own file.

@stefanpenner stefanpenner merged commit f28692e into stefanpenner:master Feb 27, 2019
@stefanpenner
Copy link
Owner

released as v1.0.3 🎉

@davecombs
Copy link
Collaborator

🎉 !

@rwjblue
Copy link
Collaborator Author

rwjblue commented Mar 8, 2019

@stefanpenner the reason Node 10 worked without this change, but Node 11 required it is due to a change (probably a bug?) in how Node 11 parses NODE_OPTIONS.

See:

@stefanpenner
Copy link
Owner

Looks like node folks fixed this in 11.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants