-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#proposal 86 introduction of feeds navigation #3916
base: master
Are you sure you want to change the base?
#proposal 86 introduction of feeds navigation #3916
Conversation
Added @username's Feed alongside "Wallet" and "Settings" on the right of the Navigation bar. Also implemented "My Feed" for when a user is logged in which is currently commented out.
Archiving the version of the restyled navigation menu that positions it at the top of the screen.
This reverts commit d246aa9.
This reverts commit b112f20.
These changes introduce a Primary Navigation across the site. The navigation uses an "App Style", bottom tab structure on mobile devices and a more traditional left navigation for Desktop. Full details of the changes are available in the following Steemit posts: Updated Files: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-edited-files New Navigation Component: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-primarynavigation-jsx-and-scss
Performance: Moved the windowHeight and navHeight calculations into the "Desktop only" scroll section. Display: Tweaked the calculations to improve how the navigation is pinned when taller than the screenHeight. Swapped the "Posts" and "Blog" labels so that "Blog" appears before "Posts" in the Profile Menu.
…://github.com/the-gorilla-steem/condenser into #proposal-86-Introduction_of_feeds_navigation
Adjusted the spacing between icons and their labels.
Where the "Load more..." link appears on the Notifications screen, it was hidden behind the 2nd level of navigation on Mobile Devices. Additional padding has been introduced to correct this.
Fixed the following issue: 1. Go to your test site or steemitdev 2. Logout 3. Go to the top-level page (or just reload the page?) 4. Login 5. A list of communities gets displayed under, "My Subscriptions", but the communities are not the ones that I subscribe to. The subscriptions were only loaded upon "componentWillMount" with a log in not constituting a remount. Therfore, if the subscriptions have not been set, they should be set upon a componentDidUpdate instead / as well.
Used componentDidUpdate in previous bug fix where componentWillUpdate will give an improved user experience (i.e. with DidUpdate, the "Trending Subscriptions" flashed up before being updated whereas "WillUpdate" has the update prepared.
This reverts commit 8259147.
"Improved Previous Bug Fix" in commit 8259147 didn't always behave as anticipated so was Reverted. |
I have deploy the newest code to test environment. |
Thank you. All of the fixes work as expected. I've raised bug #3918 against the steemit.com site which I need to fix before this code can be deployed. Whilst this bug's been present for a long time, it's now causing a bigger issue with the new navigation on Android devices. |
https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-primarynavigation-jsx-and-scss