Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nsp, update packages with vulnerabilities #2476

Merged
merged 1 commit into from Feb 8, 2018
Merged

Conversation

bnchdrff
Copy link
Contributor

@bnchdrff bnchdrff commented Feb 6, 2018

fixes #1637, #2365, and #2436

see notes starting at #2365 (comment)

@bnchdrff bnchdrff requested a review from gl2748 February 6, 2018 16:16
Copy link
Contributor

@sneak sneak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm utack

@bnchdrff
Copy link
Contributor Author

bnchdrff commented Feb 6, 2018

for the record it seems like nsp's vulnerability db isn't as comprehensive as snyk

Copy link
Contributor

@gl2748 gl2748 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working

Test Suites: 15 passed, 15 total
Tests:       127 passed, 127 total
Snapshots:   2 passed, 2 total
Time:        6.597s
Ran all test suites.
(+) No known vulnerabilities found
Done in 28.84s.

fixes #1637

update some dependencies

remove medium-editor-insert-plugin

fixes #2127

fix case in property

fixes #2475

remove purest, add blueimp-file-upload

blueimp-file-upload was an implicit dependency from the medium-editor-insert-plugin
but we explicitly require it in our webpack config

update co-body

update deps (fixes #2436) and remove fsevents (unused)

update koa-static-cache

Co-authored-by: Originate <originated@users.noreply.github.com>
@bnchdrff bnchdrff merged commit 7735ca3 into master Feb 8, 2018
bnchdrff added a commit that referenced this pull request Feb 8, 2018
This reverts commit 7735ca3, reversing
changes made to 63b561e.
bnchdrff added a commit that referenced this pull request Feb 8, 2018
Revert "Merge pull request #2476 from steemit/1637-add-nsp"
@bnchdrff bnchdrff deleted the 1637-add-nsp branch February 13, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Security Platform should be integrated and risk should be mitigated
3 participants