Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted CompletionCommand to support symfony/console 6.4 LTS #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -10,7 +10,7 @@
],
"require": {
"php": ">=8.0.2",
"symfony/console": "~6.3"
"symfony/console": "~6.4"
},
"require-dev": {
"phpunit/phpunit": "^9.5",
Expand Down
5 changes: 4 additions & 1 deletion src/CompletionCommand.php
Expand Up @@ -50,8 +50,11 @@ public function getNativeDefinition(): InputDefinition
*
* Any global options defined by user-code are meaningless to this command.
* Options outside of the core defaults are ignored to avoid name and shortcut conflicts.
*
* @param bool $appOptions
* @return void
*/
public function mergeApplicationDefinition($mergeArgs = true): void
public function mergeApplicationDefinition(bool $mergeArgs = true): void
{
// Get current application options
$appDefinition = $this->getApplication()->getDefinition();
Expand Down