enable proguard, modify rules & upgrade okhttp lib #19975
Merged
+154
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammellos
approved these changes
May 10, 2024
Jenkins BuildsClick to see older builds (119)
|
mohsen-ghafouri
approved these changes
May 10, 2024
BalogunofAfrica
approved these changes
May 10, 2024
|
hmm turning on |
Parveshdhull
approved these changes
May 10, 2024
0% of end-end tests have passedFailed tests (51)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
optimise-release-build
branch
2 times, most recently
from
180411a
to
41b5920
Compare
0% of end-end tests have passedFailed tests (51)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
optimise-release-build
branch
4 times, most recently
from
57d2572
to
31366d4
Compare
Logged a separate issue for this -> #19987 might require some more research. |
0% of end-end tests have passedFailed tests (51)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
|
The latest E2E failures are due to |
siddarthkay
force-pushed
the
optimise-release-build
branch
from
99e4772
to
b1c63e9
Compare
siddarthkay
force-pushed
the
optimise-release-build
branch
3 times, most recently
from
dea3fa1
to
a639e65
Compare
63% of end-end tests have passedFailed tests (17)Click to expandClass TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (33)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
siddarthkay
force-pushed
the
optimise-release-build
branch
from
d8c60ff
to
6f9dda5
Compare
siddarthkay
force-pushed
the
optimise-release-build
branch
from
6f9dda5
to
41eb2ff
Compare
siddarthkay
changed the title
81% of end-end tests have passedFailed tests (8)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (42)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
@yevh-berdnyk : I believe I've fixed the issues, can you pls take a look at the latest E2E result? |
siddarthkay
force-pushed
the
optimise-release-build
branch
3 times, most recently
from
a85912e
to
8ef06dc
Compare
hi @siddarthkay, thank you for the fixes! Remaining e2e failures are not related to this pull request |
|
@siddarthkay I have performed a basic manual test, no issue from my side. Ready for merge. |
This commit enables proguard minification and adds exceptions in proguard rules for the following classes : - org.bouncycastle - im.status.ethereum.BuildConfig - com.reactnativenavigation This commit also upgrades okhttp gradle dependency to 4.11.0 This should shave off a few MBs in the android bundle.
siddarthkay
force-pushed
the
optimise-release-build
branch
from
8ef06dc
to
bfef29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR turns on
proguardoptimisation and asset minification.This PR should help shave off a few MBs from PR and release builds.
After enabling
proguardwe get a savings of ~4 MB.Testing notes
Should just impact APK size but please do a basic smoke test.
Platforms
status: ready