fix(ios): autofocus input in drawer overlay won't trigger keyboard open #19964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before: RPReplay_Final1715326577.MP4after (no idea why keyboard not visible in some screenshots): RPReplay_Final1715326458.MP4RPReplay_Final1715326433.MP4RPReplay_Final1715326396.MP4 |
Jenkins BuildsClick to see older builds (16)
|
Parveshdhull
approved these changes
May 10, 2024
83% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
on my iPhone 12 Pro, this is how it works, they keyboard still does not show RPReplay_Final1715338600.mov |
|
@yqrashawn are all the screenshots from the same device or is it that the keyboard is missing on some devices? |
|
@jo-mut they are from the same device, the keyboard is somehow not captured by the video, but it's actually showing up
I'll try reproduce |
jo-mut
approved these changes
May 12, 2024
yqrashawn
force-pushed
the
fix/input-in-overlay-trigger-keyboard-open
branch
from
93ff9e8
to
0a7e402
Compare
|
Hi @jo-mut, I tested on another device (iPad 17.4.1) and the keyboard shows up automatically, so can't reproduce on all my physical iOS devices |
qoqobolo
force-pushed
the
fix/input-in-overlay-trigger-keyboard-open
branch
from
0a7e402
to
96ca678
Compare
83% of end-end tests have passedFailed tests (7)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
|
|
Thanks for the fix @yqrashawn, PR can be merged. |
yqrashawn
force-pushed
the
fix/input-in-overlay-trigger-keyboard-open
branch
2 times, most recently
from
b82a738
to
8a5bc0c
Compare
yqrashawn
force-pushed
the
fix/input-in-overlay-trigger-keyboard-open
branch
from
8a5bc0c
to
1abd6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19194
Summary
add
overlay.handleKeyboardEventsopt toshow-overlaybefore/after screenshots will be in the following comment, keyboard is not always visible in these videos
Review notes
react native navigation doc: https://wix.github.io/react-native-navigation/api/options-overlay/#handlekeyboardevents
Testing notes
this affects all usage of overlay (bottom sheet, toast, banner ...)
this only affects iOS platform
changes in this PR might impact some screens, and I'm not entirely sure if these are the desired outcomes. For instance, blur effects in below screen:
RPReplay_Final1715330782.MP4
Platforms
status: ready