New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): add recent recipients tab #19942
Conversation
Jenkins BuildsClick to see older builds (32)
|
@@ -33,7 +33,7 @@ | |||
[options-drawer/view | |||
{:name (:name collectible-details) | |||
:image (:uri preview-url)}])}]))}] | |||
:activity [activity/view {:activities []}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
@@ -58,9 +58,6 @@ | |||
:default-active @selected-tab | |||
:data (tabs-data watch-only?) | |||
:on-change (rn/use-callback (fn [tab] | |||
(when (and (= :activity tab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to account page transition
@@ -4,8 +4,6 @@ | |||
[status-im.common.resources :as status.resources] | |||
[utils.i18n :as i18n])) | |||
|
|||
(def address "0x39cf6E0Ba4C4530735616e1Ee7ff5FbCB726fBd4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
@@ -30,7 +30,8 @@ | |||
(rf/reg-event-fx :wallet/navigate-to-account | |||
(fn [{:keys [db]} [address]] | |||
{:db (assoc-in db [:wallet :current-viewing-account-address] address) | |||
:fx [[:dispatch [:navigate-to :screen/wallet.accounts address]]]})) | |||
:fx [[:dispatch [:navigate-to :screen/wallet.accounts address]] | |||
[:dispatch [:wallet/fetch-activities]]]})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch activities here
:container-style style/empty-container-style}] | ||
(into [rn/view {:style style/my-accounts-container}] | ||
(map (fn [address] | ||
[quo/address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventually this will use accounts and saved address etc too 👍
src/status_im/feature_flags.cljs
Outdated
@@ -11,7 +11,7 @@ | |||
(defonce ^:private feature-flags-config | |||
(reagent/atom | |||
{::community.edit-account-selection (enabled-in-env? :FLAG_EDIT_ACCOUNT_SELECTION_ENABLED) | |||
::wallet.activities (enabled-in-env? :FLAG_WALLET_ACTIVITY_ENABLED) | |||
::wallet.activities true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will revert/ remove this FF as it is not needed since updates in another pr:
#19906
d13af5b
to
3ac1e7a
Compare
(defn- recent-transactions | ||
[theme] | ||
(let [recent-recipients (rf/sub [:wallet/recent-recipients])] | ||
(if (zero? (count recent-recipients)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be (empty? recent-recipients)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the suggestion, will update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d14b522
to
03388f6
Compare
56% of end-end tests have passed
Failed tests (21)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (29)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
|
531dc5c
to
61c094d
Compare
87% of end-end tests have passed
Failed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hi @J-Son89 thank you for PR. One question Should the address be saved in the "Recent" tab if the user changes the network? Currently, it's not saved. Steps:
Actual result:The "Recent" tab is empty when the network is switched. If this is ok, then PR can be merged, no issues from my side |
@stefandunca - can you let me know how Desktop handled this |
AFAIK, we don't do anything special. We just call the get activity API for the current chains which will retrieve only activity filtered for that chain. Therefore, we filter out activity that is not done in the current mode which is ok. I can look into the code in detail, if you want, but I think we should not optimize yet for test networks mode, that is for developers mainly. |
2fca855
to
e82c613
Compare
fixes: #16991
This pr fetches the data for a user to send to a user they have recently sent to.
Note:
This pr is only version 1 in what is needed for this feature as in the design there is multiple versions of types of "recent" senders, i.e it can be an account, saved address or a contact.
The reason being is that the data from activities currently is not handling that information but there is a new backend end point we can update to which will get us this info moving forward.
Screen.Recording.2024-05-08.at.12.45.35.mov
Testing notes:
Go to account page,
Hit Send button
select recent tab(default)
select an address and ensure it gets sent to them
Note:
This pr does not add a new address when you send a transaction, to keep this pr smaller I will add this in a follow up pr.
For that reason feel free to feature test this pr in one go in that pr:
#19984