New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webview to 10.2.3 #10799
Merged
Merged
Update webview to 10.2.3 #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
1 similar comment
rasom
reviewed
Jun 12, 2020
vitvly
force-pushed
the
fix/webview-ssl-errors
branch
from
June 12, 2020 11:17
3e6504f
to
802b89c
Compare
flexsurfer
approved these changes
Jun 12, 2020
rasom
approved these changes
Jun 12, 2020
@siphiuel
|
This was referenced Jun 15, 2020
vitvly
force-pushed
the
fix/webview-ssl-errors
branch
from
June 17, 2020 15:17
802b89c
to
0c3dceb
Compare
@churik error is shown properly after rebasing with @flexsurfer 's fix in #10822. Did some debugging and found out that error text is ios/android specific and is generated by the native implementation, maybe we can leave it as it is. |
Failures like this:
Are caused by #10810. |
Checked:
Didn't find any issues specific to this PR. |
Signed-off-by: Vitaliy Vlasov <siphiuel@gmail.com>
vitvly
force-pushed
the
fix/webview-ssl-errors
branch
from
June 18, 2020 12:56
0c3dceb
to
3333724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes ssl error handling fix from react-native-webview/react-native-webview#1450
Partially addresses #10630 (url-spoof vulnerability will now show an error page).