Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Correct cov_kwargs -> cov_kwds #9240

Merged
merged 1 commit into from May 8, 2024

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented May 7, 2024

Consistently use cov_kwds
Fix bug that can occur in some tests due to wrong name passed to OLS.fit

closes #9121

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

Consistently use cov_kwds
Fix bug that can occur in some tests due to wrong name passed to OLS.fit

closes statsmodels#9121
@bashtage bashtage merged commit aa3c42e into statsmodels:main May 8, 2024
6 of 7 checks passed
@bashtage bashtage deleted the fix-linear-reset branch May 8, 2024 22:36
@bashtage
Copy link
Member Author

bashtage commented May 8, 2024

Random failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linear_reset can't be set with "HAC" and maxlags, KeyErrors
1 participant