New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Improve docs of regression_diagnostics.html
, stats.html
#9230
base: main
Are you sure you want to change the base?
Conversation
… and Breusch-Godfrey test for autocorrelation. Reorder some parts for better readability
Hi @josef-pkt, could you find some time to review this PR? I'll make any necessary updates. Following this PR, I'll continue working on what we discussed in issue #9099. |
Thanks, looks good can you squash this, then I will merge it (I'm taking a break from |
Great work on Do you mean we should address all the issues mentioned in #9099 and merge them at once? If so, I'll continue working on this and push to current PR. (My original plan was to fix them in separate PRs, but if you prefer to address them in a single PR, I'll start working on that.) |
A bit larger PRs, i.e. medium small PRs, are better for reviewing, combining related parts. |
Thanks for the explanation! I understand the importance of attention and time. Having a properly sized PR is indeed what we want. |
@@ -28,18 +28,15 @@ Residual Diagnostics and Specification Tests | |||
.. module:: statsmodels.stats.stattools | |||
:synopsis: Statistical methods and tests that do not fit into other categories | |||
|
|||
Autocorrelation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attempt to classify the methods, but I am uncertain about their academic accuracy.
Examples/regression_diagnostics
regression_diagnostics.html
, stats.html
Add explanations for Durbin-Watson and Kurtosis.
Include DW-test and Breusch-Godfrey test for autocorrelation.
Reorder some parts for better readability
summary
#9099NumPy's guide.
Notes:
needed for doc changes.
then show that it is fixed with the new code.
verify you changes are well formatted by running
flake8
is installed. This command is also available on Windowsusing the Windows System for Linux once
flake8
is installed in thelocal Linux environment. While passing this test is not required, it is good practice and it help
improve code quality in
statsmodels
.