Fix unsupported system page size when using Linux aarch64 (ARM64) musl binary #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes an issue when using the `aarch64-unknown-linux-musl` binary in systems with 16KB page size like Linux aarch64 (Raspberry Pi 5) by setting up jemalloc to use a maximal supported page size of 64KB on aarch64. See jemalloc/jemalloc#467#issuecomment-2054282344 It should be not a problem for system with smaller page sizes since jemalloc supports that functionality. See jemalloc/jemalloc#769 error: <jemalloc>: Unsupported system page size <jemalloc>: Unsupported system page size memory allocation of 5 bytes failed
|
Review changes with SemanticDiff. |
joseluisq
changed the title
7 tasks
joseluisq
added a commit
that referenced
this pull request
May 20, 2024
This completes the previous work on #443 by correctly setting the default 64KB system page size for jemalloc at the build config level (cross) which should be applied for develoment and production `aarch64-unknown-linux-musl` builds.
joseluisq
added a commit
that referenced
this pull request
May 20, 2024
This completes the previous work on #443 by correctly setting the default 64KB page size for jemalloc at the build config level (cross) which should be applied for development and production `aarch64-unknown-linux-musl` builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue when using the
aarch64-unknown-linux-muslbinary (Jemalloc) in Debian Linux systems with page sizes bigger than4Klike Linux aarch64 (E.g. Raspberry Pi 5 uses16Kpages).Jemalloc by default builds with the host page size so we set it up to use the maximum supported page size of
64KBon aarch64 when building SWS.jemallocwill handle systems with smaller page sizes too. See jemalloc/jemalloc#769Until Jemalloc can have a better default someday. jemalloc/jemalloc#467 (comment)
Error:
Related Issue
Fixes #440
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):