Fix regression when using empty values for --page-fallback or SERVER_FALLBACK_PAGE
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: a value is required for '--page-fallback <PAGE_FALLBACK>' but none was supplied now is ok to pass an empty --page-fallback argument or empty SERVER_FALLBACK_PAGE log example when --page-fallback or its env is empty: 2023-06-08T20:34:13.806318Z INFO static_web_server::logger: logging level: trace 2023-06-08T20:34:13.806540Z DEBUG static_web_server::server: initializing tokio runtime with multi thread scheduler self.worker_threads=8 2023-06-08T20:34:13.808290Z TRACE static_web_server::server: starting web server 2023-06-08T20:34:13.808557Z INFO static_web_server::server: server bound to tcp socket [::]:8787 2023-06-08T20:34:13.808795Z INFO static_web_server::server: fallback page: enabled=false, value=""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression when using empty values for
--page-fallbackorSERVER_FALLBACK_PAGERelated Issue
Resolves #218
Motivation and Context
How Has This Been Tested?
Provide
--page-fallback=""or itsSERVER_FALLBACK_PAGE=using empty values and run the server:Then you will see the following logs (expected):
Screenshots (if appropriate):