Support for boolean flags without explicit values #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the following boolean flag variants are now possible. implicit example: --compression -x explicit example (note the are not spaces in between): --compression=true --compression=false -x=true -x=false
|
@mac-chaffee It would be great a test from your side. |
joseluisq
force-pushed
the
boolean-flags-without-value-support
branch
from
59f2258
to
8aefcab
Compare
|
tested with --security-headers and --security-headers=false and it worked |
I also will send another PR to fix |
joseluisq
force-pushed
the
boolean-flags-without-value-support
branch
from
8aefcab
to
7970383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for hybrid boolean flags which applies to large and short boolean flag variants.
Implicit example:
Explicit example (note the are no spaces in between):
Note also that this PR migrates to the latest
clapv4.Related Issue
Resolves #209 (post enhancement of #211)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):