-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine @xstate/graph
and @xstate/test
#4896
Conversation
🦋 Changeset detectedLatest commit: 18c84c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Andarist When you get the chance, can you set this up so that it will do a proper 2.0 release? |
@Andarist Ping 🏓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I diffed this and the other one in xstate-test. They are very very similar but yet they have some very small differences. I'm confused 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changesets in #4911
@@ -5,12 +5,7 @@ | |||
"linked": [], | |||
"access": "public", | |||
"baseBranch": "main", | |||
"ignore": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: do u plan to release @xstate/graph
as a stable release soon? we probably should add @xstate/graph
back here and do some cleanup in https://github.com/statelyai/xstate/tree/7c6e2eaa4e5021738efec345b51f59a8e2de662e/.changeset-xstate-test-beta and only then execute the final release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I plan to release it soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -131,7 +131,7 @@ describe('getShortestPaths', () => { | |||
todo: 'two' | |||
} as const | |||
], | |||
filter: (state) => state.context.todos.length < 3 | |||
stopWhen: (state) => state.context.todos.length >= 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like a breaking change that wasn't mentioned in changesets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a changeset in a follow-up (clean-up) PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.