Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(preset): add symbol for Endeavour OS to gruvbox-rainbow preset #5977

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmfergeau
Copy link

Description

Adds support for the logo for Endeavour OS. Since there's apparently no icon for this one in nerd fonts, I used the Arch logo since it's Arch-based.

Motivation and Context

The change was simple but not obvious to find for Endeavour users who'd like to use this preset. (like me)

Screenshots (if appropriate):

Endeavour OS using Starship and the preset with the modification

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly. (wasn't really necessary here)
  • I have updated the tests accordingly. (couldn't test on the two others but as long as you use nerd fonts, there's no reason it shouldn't work)

Title. 

Since there's apparently no icon for this one in nerd fonts, I used the Arch logo since it's Arch-based.
@davidkna davidkna changed the title Support for Endeavour OS docs(preset/gruvbox-rainbow): add symbol for Endeavour OS May 16, 2024
@davidkna davidkna changed the title docs(preset/gruvbox-rainbow): add symbol for Endeavour OS docs(preset): add symbol for Endeavour OS to gruvbox-rainbow preset May 16, 2024
@@ -61,6 +61,7 @@ Amazon = ""
Android = ""
Arch = "󰣇"
Artix = "󰣇"
EndeavourOS = "󰣇"
Copy link
Member

@davidkna davidkna May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nerd-font preset already uses a different icon here (nf-fa-shuttle_space ). Would you mind using that instead and copying-over the other NF-icons that have been added recently?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion! It fits pretty well the space theme of Endeavour. updated it. (normally. it's hard to tell when the browser doesn't display nerd font glyphs.)

Indeed it fits pretty much Endeavour's space theme. Nice suggestion!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants