-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(nu): Simplify Nushell integration instructions #5845
base: master
Are you sure you want to change the base?
Conversation
Motivated by jdx/mise-docs#46 for consistency between tools.
ade338e
to
bdfec33
Compare
Manually picked from starship/starship#5845.
90ebebb
to
8bcb200
Compare
Reinitializes the script at most once every day. This is necessary because doing so every time could lead to thousands of concurrent writes calling `| par-each { nu -c }`.
8bcb200
to
d782659
Compare
Manually picked from starship/starship#5845.
* Update Nushell integration Depends on jdx/mise#1763 in release. * Automate reinstallation Manually picked from starship/starship#5845.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i may review this PR 😊
i think i find the
'
...
' | save $nu.env-path --append
quite harder to read 😕
Because it follows a convention of providing a command to run instead of code to add 🤓 Here's a deployed example. The currrent instructions presume the user is already familiar with the configuration docs. Starting Nu they can (I did months ago) run into issues like the files being located in an unexpected place on Mac or not having an editor configured for Starship in particular was the first thing I tried to integrate. This "just works" while providing enough context for expert users to customize as we please! |
54ada20
to
1d2f4d8
Compare
Implements @davidkna's astute feedback in #5844. Always runs unless non-interactive (a script). Clarifies and simplifies installation while reducing (possibly concurrent) file writes. RFC @amtoine (previous committer) @fdncred.