Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump chrono from 0.4.19 to 0.4.20 #4232

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

davidkna
Copy link
Member

@davidkna davidkna commented Aug 4, 2022

Description

This PR bumps chrono to v0.4.20, which fixes RUSTSEC-2020-0159. In addition, restrict the default feature set to remove the "oldtime" feature. This would also remove the dependency on time v0.1 (solving #3163), if the (default) feature wasn't getting enabled via systemstat. But their next release is going to replace chrono with time v0.3, so this ensures its update will get rid of that.

Motivation and Context

Closes #3166
Closes #4234

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkna davidkna merged commit 9220df7 into starship:master Aug 6, 2022
@davidkna davidkna deleted the bump-chrono branch August 6, 2022 17:05
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0159: Potential segfault in localtime_r invocations
2 participants