Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump path-slash from 0.1.4 to 0.2.0 #4155

Merged
merged 5 commits into from Jul 12, 2022

Conversation

cymruu
Copy link
Contributor

@cymruu cymruu commented Jul 6, 2022

adjust starship code to introduced breaking change

Closes #4151
Closes #4153

Bumps [path-slash](https://github.com/rhysd/path-slash) from 0.1.4 to 0.2.0.
- [Release notes](https://github.com/rhysd/path-slash/releases)
- [Changelog](https://github.com/rhysd/path-slash/blob/master/CHANGELOG.md)
- [Commits](rhysd/path-slash@v0.1.4...v0.2.0)

---
updated-dependencies:
- dependency-name: path-slash
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidkna
Copy link
Member

davidkna commented Jul 6, 2022

Can you make the code return/use the Cow<str> instead? That was supposed to be the advantage of the path-slash v0.2 upgrade.

@davidkna davidkna changed the title fix errors in code after path-slash bump to 0.2.0 build: bump path-slash from 0.1.4 to 0.2.0 Jul 6, 2022
@cymruu
Copy link
Contributor Author

cymruu commented Jul 6, 2022

@davidkna Sure. Any ideas how to fix contract_windows_style_root_directory test? I think it is failing because of this change rhysd/path-slash#10. Maybe we can just update expected value to include trailing slash?

@davidkna
Copy link
Member

davidkna commented Jul 7, 2022

Changing the test is probably fine.

@cymruu cymruu force-pushed the cymruu/fix-path-slash-version-bump branch from f9ef47d to 0bc44bf Compare July 7, 2022 17:23
@cymruu cymruu marked this pull request as ready for review July 7, 2022 17:51
@cymruu cymruu force-pushed the cymruu/fix-path-slash-version-bump branch from 0bc44bf to 1fd6f6b Compare July 7, 2022 17:52
@cymruu cymruu force-pushed the cymruu/fix-path-slash-version-bump branch from 1fd6f6b to 7ce6e1f Compare July 7, 2022 17:54
@cymruu cymruu changed the base branch from dependabot/cargo/path-slash-0.2.0 to master July 11, 2022 10:37
@andytom andytom merged commit f569550 into starship:master Jul 12, 2022
@andytom
Copy link
Member

andytom commented Jul 12, 2022

Thank you for your contribution @cymruu and thanks for reviewing @davidkna.

@cymruu cymruu deleted the cymruu/fix-path-slash-version-bump branch July 12, 2022 09:48
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
* build: bump path-slash from 0.1.4 to 0.2.0

Bumps [path-slash](https://github.com/rhysd/path-slash) from 0.1.4 to 0.2.0.
- [Release notes](https://github.com/rhysd/path-slash/releases)
- [Changelog](https://github.com/rhysd/path-slash/blob/master/CHANGELOG.md)
- [Commits](rhysd/path-slash@v0.1.4...v0.2.0)

---
updated-dependencies:
- dependency-name: path-slash
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix errors in code after path-slash bump to 0.2.0

* fmt

* refactor contract_path to return Cow<str>

* update contract_windows_style_root_directory test

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt path-slash 0.2.0
3 participants