Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt path-slash 0.2.0 #4151

Closed
segevfiner opened this issue Jul 5, 2022 · 0 comments · Fixed by #4155
Closed

Adopt path-slash 0.2.0 #4151

segevfiner opened this issue Jul 5, 2022 · 0 comments · Fixed by #4155
Labels
✨ enhancement A new feature implementation.

Comments

@segevfiner
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

A new path-slash version which should return a Cow instead of a String which should save performing a copy of the path on Linux when not needed.

See rhysd/path-slash#9

Describe the solution you'd like

Update to the new version, and use the Cow when possible to save copies.

Describe alternatives you've considered

Keep the existing version and some extra memcpy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement A new feature implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: bump path-slash from 0.1.4 to 0.2.0 cymruu/starship
1 participant
@segevfiner