Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add network error and timeout toast #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add network error and timeout toast #44

wants to merge 1 commit into from

Conversation

yuyongmao
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind ui-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

Which issue(s) this PR fixes:

Fixes #43

@puncsky
Copy link
Member

puncsky commented Jun 22, 2021 •
edited

Toast is bad for experiences. Let's use a panel with CTA to refresh

something like:

IMG_C003390F05B9-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitQ2019 bitQ2019 bitQ2019 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apollo fetch timeout / have error messages if timeout
3 participants
@yuyongmao @puncsky @bitQ2019