Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop to 1.12.1 #284

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

koic
Copy link
Contributor

@koic koic commented Apr 5, 2021

This PR updates RuboCop to 1.12.1.
rubocop/rubocop@v1.11.0...v1.12.1

It supports private API change from RuboCop::DirectiveComment::DIRECTIVE_COMMENT_REGEXP to RuboCop::DirectiveComment::COMMENT_DIRECTIVE_REGEXP.

And Style/StringChars cop is added in RuboCop 1.12. It is up to maintainers to decide whether to enable it :-)
rubocop/rubocop#9615

This PR updates RuboCop to 1.12.1.
rubocop/rubocop@v1.11.0...v1.12.1

It supports private API change from `RuboCop::DirectiveComment::DIRECTIVE_COMMENT_REGEXP`
to `RuboCop::DirectiveComment::COMMENT_DIRECTIVE_REGEXP`.

- rubocop/rubocop@7f1f75c
- rubocop/rubocop@0421710

And `Style/StringChars` cop is added in RuboCop 1.12. It is up to maintainers to
decide whether to enable it :-)
rubocop/rubocop#9615
@jmkoni jmkoni merged commit ce7645b into standardrb:master Apr 5, 2021
@jmkoni
Copy link
Contributor

jmkoni commented Apr 5, 2021

thank you @koic 😄

@koic koic deleted the update_rubocop_to_1_12_1 branch April 5, 2021 12:52
@bobmaerten
Copy link
Contributor

Could you make a release from this dependency upgrade?
I use standard in conjonction with rubocop-daemon to enable autocorrect on save with my editor and there a dependency error since a couple of days:
Unable to activate standard-1.0.4, because rubocop-1.12.1 conflicts with rubocop (= 1.11.0)

Thanks

@jmkoni
Copy link
Contributor

jmkoni commented Apr 14, 2021

@bobmaerten just released!

@bobmaerten
Copy link
Contributor

Thank you, so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants