Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obj.instance_eval("SomeStrings") is not handled correctly #275

Closed
ngiger opened this issue Mar 18, 2021 · 1 comment · Fixed by rubocop/rubocop#9616
Closed

obj.instance_eval("SomeStrings") is not handled correctly #275

ngiger opened this issue Mar 18, 2021 · 1 comment · Fixed by rubocop/rubocop#9616
Labels
rubocop bug 🚨 An apparent bug in RuboCop

Comments

@ngiger
Copy link

ngiger commented Mar 18, 2021

File test_eval.rb looks like this

def mytest
    xxx = String.new
    xxx.instance_eval('@additional_javascripts = additional_javascripts')
end

After running bundle exec standardrb test_eval.rb --fix it looks like this

def mytest
  xxx = ""
    xxx.instance_eval("@additional_javascripts = additional_javascripts"), __FILE__, __LINE__
end

which is not correct
@ngiger ngiger mentioned this issue Mar 18, 2021
Closed
koic added a commit to koic/rubocop that referenced this issue Mar 18, 2021
@koic
Fix an incorrect auto-correct for Style/EvalWithLocation
10aa0cc 
Fixes standardrb/standard#275.

This PR fixes the following incorrect auto-correct for `Style/EvalWithLocation`
when using `#instance_eval` with a string argument in parentheses.

```console
% cat example.rb
instance_eval('@foo = foo')

% rubocop -A --only Style/EvalWithLocation
(snip)

Inspecting 1 file
C

Offenses:

example.rb:1:1: C: [Corrected] Style/EvalWithLocation: Pass __FILE__ and
__LINE__ to instance_eval.
instance_eval('@foo = foo')
^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
```

## Before

```console
% cat example.rb
instance_eval('@foo = foo'), __FILE__, __LINE__

% ruby -c example.rb
example.rb:1: syntax error, unexpected ',', expecting end-of-input
instance_eval('@foo = foo'), __FILE__, __LINE__
```

## After

```console
% cat example.rb
instance_eval('@foo = foo', __FILE__, __LINE__)

% ruby -c example.rb
Syntax OK
```
@koic koic mentioned this issue Mar 18, 2021
Merged
8 tasks
@koic
Copy link
Contributor

koic commented Mar 18, 2021

Thank you for opening the issue. This is a RuboCop's bug and I opened rubocop/rubocop#9616 to RuboCop core.

@jmkoni jmkoni added the rubocop bug 🚨 An apparent bug in RuboCop label Mar 19, 2021
@jmkoni jmkoni closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rubocop bug 🚨 An apparent bug in RuboCop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an incorrect auto-correct for Style/EvalWithLocation koic/rubocop
3 participants
@koic @ngiger @jmkoni