Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard formatting for all ruby files #134

Closed
ngiger opened this issue Mar 17, 2021 · 2 comments
Closed

Use standard formatting for all ruby files #134

ngiger opened this issue Mar 17, 2021 · 2 comments

Comments

@ngiger
Copy link
Collaborator

ngiger commented Mar 17, 2021

See https://github.com/testdouble/standard
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 17, 2021
@ngiger
(zdavatz#134) Add some files for using standardrb
ef6326b
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 17, 2021
@ngiger
(zdavatz#134) standardrb. add some test files
61ef878
@ngiger
Copy link
Collaborator Author

ngiger commented Mar 18, 2021

Open the issue standardrb/standard#275 as we often use instance_eval in our tests. Corrected them all by hand

ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 19, 2021
@ngiger
(zdavatz#134) After standardrb --fix in all test files + manual fixes
152fe8b
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 19, 2021
@ngiger
(zdavatz#134) standardrb --fix for some more test files
1d1234b
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 19, 2021
@ngiger
(zdavatz#134) Try to find error
bd21335
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 19, 2021
@ngiger
(zdavatz#134) Avoid error for PointerArray test
bc1a894
ngiger added a commit to ngiger/oddb.org that referenced this issue Mar 19, 2021
@ngiger
(zdavatz#134) Ran standardrb --fix for all src files
4dbdad4
@ngiger
Copy link
Collaborator Author

ngiger commented Mar 19, 2021

Ich habe gerade gesehen, dass ext/fipdf nicht leer ist. Meiner Meinung nach laufen die PDF-Export seit 2011 nicht mehr. Siehe auf thinpower

rw-r--r-- 1 apache apache 110946527 14. Dez 2011  ./data/downloads/fachinfos_de.pdf
-rw-r--r-- 1 apache apache 113473921 14. Dez 2011  ./data/downloads/fachinfos_fr.pdf

Der dazugehörende jobs check_swissmedicno_fi_pi findet man weder im src/util/updater noch im crontab.

Irgendwie wurde das nicht konsequent ausgebaut. Ist das okay, wenn ich das gesamte ext/fipdf/ lösche? Soll ich dazu ein separaates issue erstellen? Dort hat es nämlich viele Stellen, wo standardrb reklamiert.

@zdavatz zdavatz mentioned this issue Mar 19, 2021
Closed
@zdavatz zdavatz closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zdavatz @ngiger