Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.X #1725

Merged
merged 3 commits into from Jan 31, 2022
Merged

feat: support ESLint 8.X #1725

merged 3 commits into from Jan 31, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 10, 2021

@welcome
Copy link

welcome bot commented Oct 10, 2021

🙌 Thanks for opening this pull request! You're awesome.

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! 🙏

I added some suggestions on how you can try to limit the scope to the smallest possible, thus making it easier to review and merge this change.

When it comes to bumping the engine range to "node": "^12.22.0 || ^14.17.0 || >=16.0.0" – feel free to add a dedicated PR for that and we can get that merged separately in preparation for ESLint 8 – else we can do it in here as well, but nothing in that sync stops it from going in already.

.github/workflows/test-external.yml Outdated Show resolved Hide resolved
.github/workflows/test-internal.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@aladdin-add
Copy link
Contributor

eslint-config-standard@v17.0.0-0 has been released. /cc @MichaelDeBoey

package.json Outdated Show resolved Hide resolved
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
@voxpelli
Copy link
Member

We are continuing to work towards this. Thanks for the patience everyone 🙏

@theoludwig theoludwig marked this pull request as ready for review January 31, 2022 19:39
@voxpelli voxpelli merged commit e25e9da into standard:master Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

🎉 Congrats on getting your first pull request landed!

@theoludwig
Copy link
Member

Thanks for your work! @MichaelDeBoey ❤️

@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch January 31, 2022 20:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
4 participants