Update README.md with working Typescript setup #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the current Typescript setup would incorrectly emit unused-variable errors (e.g: when you import interfaces):sweat_smile:. Related to standard#1283
|
Thank you for your contribution, @ahimta. Thank you for the contribution, @ahimta. I see this as another call to provide a means to include https://github.com/standard/eslint-config-standard-with-typescript in Standard. Perhaps we should re-examine #703? I will leave reviewing to someone who indeed looked at standardx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the current Typescript setup would incorrectly emit unused-variable errors (e.g: when you import interfaces):sweat_smile:.
Related to #1283
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Just the Typescript section of the readme file:smiley:.
Is there anything you'd like reviewers to focus on?
Closing the related issue if appropriate:sweat_smile:.