Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object shorthand for properties #219

Merged
merged 3 commits into from Apr 30, 2020
Merged

Use object shorthand for properties #219

merged 3 commits into from Apr 30, 2020

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented Apr 25, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: lint update

What changes did you make? (Give an overview)

I started using object shorthand for properties, that is, I changed eslint: eslint to eslint.

Which issue (if any) does this pull request address?

standard/eslint-config-standard#166

Is there anything you'd like reviewers to focus on?

The three lines changed πŸ˜…


Compatibility: This is supported on Node.js >=4, and we are using Object.assign which also became available in that version βœ…

Copy link
Contributor

@toddbluhm toddbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not sure why travis is failing though?!

Perhaps we should add a minimum node version to the package.json as well?

@toddbluhm
Copy link
Contributor

I was just going to say, maybe merge this after: #213?

@LinusU
Copy link
Member Author

LinusU commented Apr 30, 2020

Will do βœ”οΈ

@LinusU LinusU merged commit ab4f1af into master Apr 30, 2020
@LinusU LinusU deleted the object-shorthand branch April 30, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants